RE: timestamp in coff header breaks ld testsuite

["Donn Terry" <donnte at microsoft dot com>]

This patch should help.   I believe it was submitted over two years ago,
but never got applied,
I guess.  Refreshing this stuff will occur, but it depends on resources
exactly when.
(Yes, I have appropriate releases on file with FSF.)

Donn

diff -urpPd --exclude-from=exclude.files
//Q/Gnusrc/cygwin.0404/ld/testsuite/ld-
bootstrap/bootstrap.exp
//D/home/donn.intel/be.build/ld/testsuite/ld-bootstrap/b
ootstrap.exp
--- //Q/Gnusrc/cygwin.0404/ld/testsuite/ld-bootstrap/bootstrap.exp
Sun Apr
 4 03:15:38 1999
+++ //D/home/donn.intel/be.build/ld/testsuite/ld-bootstrap/bootstrap.exp
Mon Apr 12 11:22:07 1999
@@ -127,9 +130,16 @@ foreach flags {"" "strip" "--static" "--
        }
     }

-    send_log "cmp tmpdir/ld2 tmpdir/ld3\n"
-    verbose "cmp tmpdir/ld2 tmpdir/ld3"
-    catch "exec cmp tmpdir/ld2 tmpdir/ld3" exec_output
+    send_log "compare tmpdir/ld2 tmpdir/ld3\n"
+    verbose "compare tmpdir/ld2 tmpdir/ld3"
+    # Trim off the date
+    # Altho this works, a way to poke the date would be better;
+    # Removing the date stamp completely has met with objections from
+    # end users.
+    exec tail +140 tmpdir/ld2 >tmpdir/ld2tail
+    exec tail +140 tmpdir/ld3 >tmpdir/ld3tail
+    catch "exec cmp tmpdir/ld2tail tmpdir/ld3tail" exec_output
+    exec rm tmpdir/ld2tail tmpdir/ld3tail
     set exec_output [prune_warnings $exec_output]

     if [string match "" $exec_output] then {


-----Original Message-----
From: egor duda [mailto:deo@logos-m.ru] 
Sent: Friday, November 09, 2001 9:58 AM
To: Nick Clifton
Cc: Donn Terry; binutils@sources.redhat.com
Subject: Re: timestamp in coff header breaks ld testsuite


Hi!

Friday, 09 November, 2001 Nick Clifton nickc@cambridge.redhat.com wrote:

NC> Hi Donn,

>> PEI does want the timestamps.

NC> OK - thanks for speaking up.  Now that I know that it really is 
NC> needed I will not consider removing it.

yes, it'd be a bit harsh...

>> And there is (or was, unless somone ripped it out) code to deal with 
>> the regression tests and timestamps. (But it isn't pretty.)

those tests are just set to xfail for coff-based targets. it's not good
because we may miss real bugs.

NC> Hmm, I guess I will have to have a look.  Egor - which tests are you

NC> seeing fail because of the timestamps ?

all ld bootstrap tests:

Running target unix
Running
/cygdrive/j/src/sourceware/src/ld/testsuite/ld-bootstrap/bootstrap.exp
...
FAIL: bootstrap
FAIL: bootstrap with strip
FAIL: bootstrap with --static
FAIL: bootstrap with --traditional-format
FAIL: bootstrap with --no-keep-memory

they're all saying that

cmp tmpdir/ld2 tmpdir/ld3
tmpdir/ld2 tmpdir/ld3 differ: char 137, line 2
child process exited abnormally

Egor.            mailto:deo@logos-m.ru ICQ 5165414 FidoNet 2:5020/496.19