This is the mail archive of the binutils@sources.redhat.com mailing list for the binutils project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]

Re: [PATCH] basename buffer gets spammed in `ld'

On Sat, Jul 14, 2001 at 09:47:50AM -0700, H . J . Lu wrote:
> On Sat, Jul 14, 2001 at 09:39:34AM -0700, David O'Brien wrote:
> > > 
> > > > > basename() calls needed to be wrapped with xstrdup it appeared to me this
> > > > > basename() call was wrapped in xstrdup for the same reason.
> > > > 
> > > 
> > > I don't like such kind of change. Unless it is broken, don't fix
> > > it :-).
> > 
> > The current code is broken (ie, has bugs that are biting FreeBSD users).
> 
> My comment was for the xstrdup change, which is not broken. If you go
> back, you can see it is the part of your patch we are discussing. 

Why are you still discussing the older patch vs. the one that was at the
bottom of the email you replied to?
 
-- 
-- David  (obrien@FreeBSD.org)
Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]