This is the mail archive of the binutils@sources.redhat.com mailing list for the binutils project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]

Re: PATCH: Fix cpu-i960.c


On Mon, Jun 25, 2001 at 10:50:28AM +0930, Alan Modra wrote:
> On Sun, Jun 24, 2001 at 09:08:44AM -0700, H . J . Lu wrote:
> > --- cpu-i960.c	2001/03/09 19:15:44	1.1.1.4
> > +++ cpu-i960.c	2001/06/24 16:00:19
> > @@ -33,14 +33,10 @@ scan_960_mach (ap, string)
> >       const char *string;
> >  {
> >    unsigned long machine;
> > -  int i;
> >    int fail_because_not_80960 = false;
> >  
> > -  for (i = 0; i < strlen (string); i ++)
> > -    string[i] = tolower (string[i]);
> > -
> 
> Shouldn't you just remove the above, and not bother with strcasecmp below?
> See read.c, IGNORE_OPCODE_CASE
 
I just fixed the obvious problem. Nothing more.


H.J.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]