Re: "Fix" strip test failure

["H . J . Lu" <hjl at lucon dot org>]

On Mon, Apr 30, 2001 at 10:46:18PM +0200, Andreas Jaeger wrote:
> 
> Running the testsuite on i686-linux with glibc 2.2 gives the following
> error:
> /builds/sourceware-src/build-binutils-ln/binutils/strip-new  tmpdir/testprog.o
> Executing on host: /builds/sourceware-src/build-binutils-ln/binutils/strip-new  tmpdir/testprog.o   (timeout = 300)
> bucomm.o: In function `make_tempname':
> /cvs/binutils-gdb-ln/binutils/bucomm.c:246: the use of `mktemp' is dangerous, better use `mkstemp'
> bucomm.o: In function `make_tempname':
> /cvs/binutils-gdb-ln/binutils/bucomm.c:246: the use of `mktemp' is dangerous, better use `mkstemp'
> 
> FAIL: strip
> 
> The problem is that libtool rebuilds strip and thereby emits this
> warning :-(.
> 
> You can check this problem if you run the testsuite twice in the
> binutils directory.  The first time it will fail for ld, the second
> time not.
> 
> What do you think of the appended patch?  Or is there a better
> solution?
> 

My Linux binutils has no problems. I have fixed it long time ago:

http://sources.redhat.com/ml/binutils/2000-10/msg00047.html

But my patch was not accepted :-(.


H.J.