This is the mail archive of the binutils@sources.redhat.com mailing list for the binutils project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]

Re: [PATCH] OpenRISC support for BFD


Johan Rydberg <johan.rydberg@netinsight.se> writes:

> Here's a patch for libbfd that add support for the OpenRISC architecture.
> 
> /src/bfd:
> 
>         * cpu-openrisc.c: New file.
>         * elf32-openrisc.c: Likewise.
> 
>         * Makefile.am (ALL_MACHINES): Add cpu-openrisc.lo.
>         (ALL_MACHINES_CFILES): Add cpu-openrisc.c.
>         (BFD32_BACKENDS): Add elf32-openrisc.lo.
>         (BFD32_BACKENDS_CFILES): Add elf32-openrisc.c.
>         (cpu-openrisc.lo, elf32-openrisc.lo): New rules.
>         * Makefile.in: Regenerated.
>         * config.bfd: (openrisc-*-elf): New target.
>         * configure.in (bfd_elf32_openrisc_vec): New vector.
>         * configure: Regenerated.
>         * libbfd.h: Regenerated.
>         * bfd-in2.h: Regenerated.
>         * reloc.c: Add OpenRISC relocations.
>         * targets.c (bfd_elf32_openrisc_vec): Declare.
>         (bfd_target_vect): Add bfd_elf32_openrisc_vec.
>         * archures.c (enum bfd_architecture): Add bfd_arch_openrisc.
>         (bfd_openrisc_arch): Declare.
>         (bfd_archures_list): Add bfd_openrisc_arch.
>         * elf.c (prep_headers): Add bfd_arch_openrisc.
> 
> 
> /src/include/elf:
> 
>         * openrisc.h: New file.
>         * common.h (EM_OPENRISC): New constant.

Just a few comments:
- no need to send patches for generated files like configure, just add
  a comment as regenerated to the ChangeLog and the person doing the
  check in will regenerate it.
- Can't you get an official EM_OPENRISC constant - even without a ABI?
- please don't send ChangeLog entries as diffs, they'll never apply correctly.

Excuse my ignorerance but what is the OpenRISC architecture?  Do you
have a URL for it?

Others have to comment on the rest of the patch,
Andreas
-- 
 Andreas Jaeger
  SuSE Labs aj@suse.de
   private aj@arthur.inka.de
    http://www.suse.de/~aj


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]