This is the mail archive of the
binutils@sources.redhat.com
mailing list for the binutils project.
Re: A patch to fix COFF
On Fri, Feb 23, 2001 at 12:27:41PM -0800, Nick Clifton wrote:
>
> > If you want to go this way, please check all of them and make sure
> > they are all ok. I know config/tc-i386.c is not.
>
> Sorry - what is wrong with tc-i386.c ? I mean, what would break if we
> patched it as suggested ?
Yes, it needs a similar patch. I noticed the failure after I enabled
the i386/COFF test disabled by accident :-).
> I think that you have persuaded me, although I do have one small
> reservation - shouldn't the non BFD_ASSEMBLER version of
> dwarf2_directive_file() always pass 0 onto s_app_file(), rather than
> passing on its appfile argument ?
>
I think you are right. Here is a new patch.
--
H.J. Lu (hjl@valinux.com)
---
2001-02-23 H.J. Lu <hjl@gnu.org>
* dwarf2dbg.c (dwarf2_directive_file): Call s_app_file (0) if
BFD_ASSEMBLER is not defined.
Index: dwarf2dbg.c
===================================================================
RCS file: /work/cvs/gnu/binutils/gas/dwarf2dbg.c,v
retrieving revision 1.19
diff -u -p -r1.19 dwarf2dbg.c
--- dwarf2dbg.c 2001/02/03 23:13:19 1.19
+++ dwarf2dbg.c 2001/02/23 20:37:31
@@ -1284,7 +1284,7 @@ void
dwarf2_directive_file (dummy)
int dummy ATTRIBUTE_UNUSED;
{
- as_fatal (_("dwarf2 is not supported for this object file format"));
+ s_app_file (0);
}
void