This is the mail archive of the
binutils@sources.redhat.com
mailing list for the binutils project.
SH assembler emits incorrect warnings
- To: rth at redhat dot com
- Subject: SH assembler emits incorrect warnings
- From: Alexandre Oliva <aoliva at redhat dot com>
- Date: 09 Feb 2001 16:12:36 -0200
- Cc: binutils at sources dot redhat dot com
- Organization: GCC Team, Red Hat
Ever since the following patch was installed, a sh-elf toolchain will
emit a number of warnings whenever a constant in debugging info,
encoded with .[248]byte, happens to come up mis-aligned.
2000-12-28 Richard Henderson <rth@redhat.com>
* config/tc-sh.c (sh_cons_align): Use rs_align_test.
(sh_handle_align): Likewise. Handle rs_align_code.
(sh_do_align): Remove.
* config/tc-sh.h (md_do_align): Remove.
(MAX_MEM_FOR_RS_ALIGN_CODE): New.
Here's a patch that gets us rid of the inappropriate warnings. While
I was at it, I introduced .uaquad, that seems like a reasonable
parallel to .quad.
Ok to install in release branch and mainline?
Index: gas/ChangeLog
from Alexandre Oliva <aoliva@redhat.com>
* config/tc-sh.c (md_pseudo_table): Add uaquad. Use s_uacons for
2byte, 4byte and 8byte.
Index: gas/config/tc-sh.c
===================================================================
RCS file: /cvs/src/src/gas/config/tc-sh.c,v
retrieving revision 1.33
diff -u -p -r1.33 tc-sh.c
--- gas/config/tc-sh.c 2000/12/28 10:07:56 1.33
+++ gas/config/tc-sh.c 2001/02/09 18:10:04
@@ -1,5 +1,6 @@
/* tc-sh.c -- Assemble code for the Hitachi Super-H
- Copyright (C) 1993, 94, 95, 96, 97, 98, 99, 2000 Free Software Foundation.
+ Copyright (C) 1993, 1994, 1995, 1996, 1997, 1998, 1999, 2000, 2001
+ Free Software Foundation.
This file is part of GAS, the GNU Assembler.
@@ -92,8 +93,12 @@ const pseudo_typeS md_pseudo_table[] =
{"uses", s_uses, 0},
{"uaword", s_uacons, 2},
{"ualong", s_uacons, 4},
- { "file", dwarf2_directive_file, 0 },
- { "loc", dwarf2_directive_loc, 0 },
+ {"uaquad", s_uacons, 8},
+ {"2byte", s_uacons, 2},
+ {"4byte", s_uacons, 4},
+ {"8byte", s_uacons, 8},
+ {"file", dwarf2_directive_file, 0 },
+ {"loc", dwarf2_directive_loc, 0 },
{0, 0, 0}
};
--
Alexandre Oliva Enjoy Guarana', see http://www.ic.unicamp.br/~oliva/
Red Hat GCC Developer aoliva@{cygnus.com, redhat.com}
CS PhD student at IC-Unicamp oliva@{lsd.ic.unicamp.br, gnu.org}
Free Software Evangelist *Please* write to mailing lists, not to me