This is the mail archive of the
binutils@sources.redhat.com
mailing list for the binutils project.
Re: Your patch on 2001-01-26 is bad
On Thu, Feb 08, 2001 at 05:59:56PM -0800, Richard Henderson wrote:
> On Thu, Feb 08, 2001 at 05:52:54PM -0800, H . J . Lu wrote:
> > Can you elaborate on that? I wrote the ld visibility tests. I couldn't
> > find what you claimed.
>
> See
>
> } else { if [ string match $visibility "hidden_weak" ] {
> set VSBCFLAG "-DHIDDEN_WEAK_TEST"
>
And? In sh1.c:
#ifdef HIDDEN_WEAK_TEST
#define HIDDEN_UNDEF_TEST
#define WEAK_TEST
#endif
It tests hidden, weak and undefined. Did I miss something obvious?
H.J.
--
H.J. Lu (hjl@valinux.com)