This is the mail archive of the binutils@sources.redhat.com mailing list for the binutils project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]

Re: The top-level configure uses $() variables


On Fri, Jan 19, 2001 at 04:16:03PM -0800, Richard Henderson wrote:
> On Fri, Jan 19, 2001 at 09:34:31PM +0100, Maciej W. Rozycki wrote:
> >  In short: $() variable references cause problems with sh and as a result
> > such invocations as:
> 
> Let's hear the long explanation instead.
> 
> Each place you've changed is supposed to already be quoted so that sh
> does nothing but pass the whole construct through to make.  So () vs {}
> shouldn't matter.

Speaking as something with absolutely zero authority over binutils:

Even if they don't, I hope this patch would be accepted.  $() and ${} are
the same thing under make, but have completely different meanings under sh.
For wrapping variables, only {} means the same for both programs.  We should
be using {} in shell scripts just for continuity, if for no other reason.

-- 
pedwards at disaster dot jaj dot com  |  pme at sources dot redhat dot com
devphil at several other less interesting addresses in various dot domains
The gods do not protect fools.  Fools are protected by more capable fools.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]