This is the mail archive of the
binutils@sources.redhat.com
mailing list for the binutils project.
Re: readelf .debug_line fix
- To: rth at redhat dot com
- Subject: Re: readelf .debug_line fix
- From: Nick Clifton <nickc at redhat dot com>
- Date: Fri, 17 Nov 2000 10:56:56 -0800
- CC: binutils at sources dot redhat dot com
Hi Richard,
: info.li_length is a bfd_vma; the size of the external length field
: is exactly 4. Thus using sizeof is incorrect, and in fact results
: in garbage on Alpha.
: /* Check the length of the block. */
: info.li_length = BYTE_GET (external->li_length);
: ! if (info.li_length + 4 > section->sh_size)
: ! end_of_sequence = data + info.li_length + 4;
I think it would be clearer if you used "sizeof (external->li_length)"
here instead of the constant 4.
Cheers
Nick