This is the mail archive of the
binutils@sources.redhat.com
mailing list for the binutils project.
Re: struct gmon_cg_arc_record
- To: jes at linuxcare dot com
- Subject: Re: struct gmon_cg_arc_record
- From: Ian Lance Taylor <ian at zembu dot com>
- Date: 14 Nov 2000 20:23:49 -0800
- CC: drepper at cygnus dot com, libc-hacker at sourceware dot cygnus dot com, binutils at sourceware dot cygnus dot com
- References: <200011141926.UAA20529@lxplus015.cern.ch> <m3ofzis52d.fsf@otr.mynet.cygnus.com> <d3r94eux9b.fsf@lxplus015.cern.ch> <m3aeb2s33g.fsf@otr.mynet.cygnus.com> <d3n1f2uvxu.fsf@lxplus015.cern.ch> <m34s1as27q.fsf@otr.mynet.cygnus.com> <d3itpquuhv.fsf@lxplus015.cern.ch> <m3n1f2qm6p.fsf@otr.mynet.cygnus.com> <d3em0eur8p.fsf@lxplus015.cern.ch>
From: Jes Sorensen <jes@linuxcare.com>
Date: 14 Nov 2000 23:24:22 +0100
- /* FIXME: Checking a host compiler define means that we can't use
- a cross gprof to the alpha. */
-#ifdef __alpha__
- char low_pc[8]; /* base pc address of sample buffer */
- char high_pc[8]; /* max pc address of sampled buffer */
-#else
- char low_pc[4]; /* base pc address of sample buffer */
- char high_pc[4]; /* max pc address of sampled buffer */
-#endif
+ char low_pc[sizeof (char *)]; /* base pc address of sample buffer */
+ char high_pc[sizeof (char *)]; /* max pc address of sampled buffer */
Yuck. If we're going to touch this, can't we avoid sizeof(char*)? It
prevents cross-configurations, and there is no particular reason to
believe that it is correct on any given system. At the very least
make it something which can be configured for a particular system,
rather than trusting that the compiler and the C library agree on this
size.
Ian