This is the mail archive of the binutils@sources.redhat.com mailing list for the binutils project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]

Re: Instruction packing with --gstabs for d10v assembler


Hi Matt,

: 2000-11-06  Matthew Hiller  <hiller@redhat.com>
: 
: 	* config/tc-d10v.c (flag_allow_gstabs_packing): New variable.
: 	(md_longopts): New options --gstabs-packing, --no-gstabs-packing.
: 	(md_show_usage): Ditto.
: 	(md_parse_option): Ditto.
: 	(d10v_cleanup): Writes pending instruction only if
: 	!outputting_line_debug_p || !flag_allow_gstabs_packing.
: 	* doc/c-d10v.texi: Documents new options.

Approved.

Just be really annoying, there is one very minor thing that you might
like to clean up though:

      /* True if instruction swapping warnings should be inhibited.  */
    ! static unsigned char flag_warn_suppress_instructionswap; /* --nowarnswap.  */
    ! /* True if instruction packing should be performed when --gstabs is specified.
    !    --gstabs-packing, --no-gstabs-packing.  */
    ! static unsigned char flag_allow_gstabs_packing = 1;

A blank line seperating these declarations would be nice.

Cheers
	Nick

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]