Misapplied patch breakage

[msokolov at ivan dot Harhan dot ORG (Michael Sokolov)]

Nick,

Would you mind explaining why did you take the liberty of incorrectly changing
an absolute reloc to a PC-relative one while applying my last patch? And would
you mind checking this in right away to fix it:

2000-10-18  Michael Sokolov  <msokolov@ivan.Harhan.ORG>

	* config/tc-m68k.c: Fix the previous misapplied patch.

Index: config/tc-m68k.c
===================================================================
RCS file: /cvs/src/src/gas/config/tc-m68k.c,v
retrieving revision 1.13
diff -c -r1.13 tc-m68k.c
*** tc-m68k.c	2000/10/18 17:42:27	1.13
--- tc-m68k.c	2000/10/18 18:10:07
***************
*** 4383,4389 ****
  	  fragP->fr_opcode[0] = 0x4E;
  	  fragP->fr_opcode[1] = (char) 0xB9; /* JSR with ABSL LONG operand */
  	  fix_new (fragP, fragP->fr_fix, 4, fragP->fr_symbol, fragP->fr_offset,
! 		   0, RELAX_RELOC_PC32);
  	  fragP->fr_fix += 4;
  	}
        else if (fragP->fr_opcode[0] == 0x60)	/* jbra */
--- 4383,4389 ----
  	  fragP->fr_opcode[0] = 0x4E;
  	  fragP->fr_opcode[1] = (char) 0xB9; /* JSR with ABSL LONG operand */
  	  fix_new (fragP, fragP->fr_fix, 4, fragP->fr_symbol, fragP->fr_offset,
! 		   0, RELAX_RELOC_ABS32);
  	  fragP->fr_fix += 4;
  	}
        else if (fragP->fr_opcode[0] == 0x60)	/* jbra */

The BRABSJUNC relaxation mode is for relaxing an unconditional jump between a
byte branch (8-bit PC-relative), a word branch (16-bit PC-relative), and an
absolute jump (32-bit absolute), and in the LONG state it generates a 32-bit
absolute jump. I believe that my comments in the code explaining all this are
clear enough for anyone to understand easily, and I just can't think what could
have suggested to you that there should be a PC32 reloc in there rather than an
ABS32 one, especially only for jbsr and not for jbra (you've only changed it in
the jbsr case).

With all due respect, Nick, I would really appreciate it if you could either
check my patches in as posted, or say "No, I would rather have you do it this
way", or "Would you mind explaining this", or anything else other saying
"Approved and applied" and silently checking in a patch different from the one
posted and sometimes incorrect.

--
Michael Sokolov		Harhan Engineering Laboratory
Public Service Agent	International Free Computing Task Force
			International Engineering and Science Task Force
			615 N GOOD LATIMER EXPY STE #4
			DALLAS TX 75204-5852 USA

Phone: +1-214-824-7693 (Harhan Eng Lab office)
E-mail: msokolov@ivan.Harhan.ORG (ARPA TCP/SMTP) (UUCP coming soon)