This is the mail archive of the binutils@sources.redhat.com mailing list for the binutils project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]

Re: -Bgroup and -z defs


Hi Uli,

: I'd like to commit the appended patch which implements the -Bgroup
: and the -z defs option the Solaris linker knows about.  -Bgroup
: introduces something new (which is trivially to implement) and -z
: defs is an alias for --no-undefined.

There are a couple of problems with the patch:

  1. You should add documentation to as.texinfo, ld.1 and NEWS about
     these new features.

  2. The second addition of the "Bgroup" switch is unnecessary:

:    {"enable-new-dtags", no_argument, NULL, OPTION_ENABLE_NEW_DTAGS},
: +  {"Bgroup", no_argument, NULL, OPTION_GROUP},
: +  {"Bgroup", no_argument, NULL, OPTION_GROUP},


Fix these and I'll approve it.

Cheers
	Nick

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]