This is the mail archive of the
binutils@sources.redhat.com
mailing list for the binutils project.
Your patch breaks i386-pe gas
- To: snowball3 at bigfoot dot com
- Subject: Your patch breaks i386-pe gas
- From: "H . J . Lu" <hjl at valinux dot com>
- Date: Wed, 16 Aug 2000 12:23:09 -0700
- Cc: nickc at cygnus dot com, binutils at sourceware dot cygnus dot com
This patch breaks gas/testsuite/gas/all/cofftag.s under i386-pe:
../as-new -o dump.o /work/gnu/src/binutils/gas/testsuite/gas/all/cofftag.s
/work/build/gnu/bin/binutils/gas-ix86-pe/testsuite/../../binutils/objdump -t
dump.o > dump.out
regexp_diff match failure
regexp "^\[ 6\]\(sec -1\)\(fl 0x00\)\(ty b\)\(scl 16\) \(nx 0\) 0x0+0000
_operator$"
line "[ 6](sec -2)(fl 0x00)(ty b)(scl 16) (nx 0) 0x00000000 _operator"
regexp_diff match failure
regexp "^\[ 7\]\(sec -1\)\(fl 0x00\)\(ty b\)\(scl 16\) \(nx 0\) 0x0+0001
_flags$"
line "[ 7](sec -2)(fl 0x00)(ty b)(scl 16) (nx 0) 0x00000001 _flags"
regexp_diff match failure
regexp "^\[ 8\]\(sec -1\)\(fl 0x00\)\(ty 0\)\(scl 102\) \(nx 1\) 0x0+0004
.eos$"
line "[ 8](sec -2)(fl 0x00)(ty 0)(scl 102) (nx 1) 0x00000004 .eos"
FAIL: cofftag
I don't know COFF. If the patch is correct, could you please also fix
gas/testsuite/gas/all/cofftag.s and gas/testsuite/gas/all/cofftag.d?
Thanks.
--
H.J. Lu (hjl@gnu.org)
---
2000-08-14 Mark Elbrecht <snowball3@bigfoot.com>
* config/obj-coff.c (obj_coff_endef) [BFD_ASSEMBLER]: Set the debug
flag for storage types C_ARG, C_REGPARM, C_FIELD, C_MOS, C_MOE,
C_MOU, and C_EOS.
Index: config/obj-coff.c
===================================================================
RCS file: /cvs/src/src/gas/config/obj-coff.c,v
retrieving revision 1.32
retrieving revision 1.33
diff -u -p -r1.32 -r1.33
--- obj-coff.c 2000/07/24 17:50:35 1.32
+++ obj-coff.c 2000/08/14 19:41:40 1.33
@@ -732,14 +732,11 @@ obj_coff_endef (ignore)
case C_ARG:
case C_REGPARM:
case C_FIELD:
- SF_SET_DEBUG (def_symbol_in_progress);
- S_SET_SEGMENT (def_symbol_in_progress, absolute_section);
- break;
-
case C_MOS:
case C_MOE:
case C_MOU:
case C_EOS:
+ SF_SET_DEBUG (def_symbol_in_progress);
S_SET_SEGMENT (def_symbol_in_progress, absolute_section);
break;