Re: [patch] AVR disassembler fixes

[Denis Chertykov <denisc at overta dot ru>]

Marek Michalkiewicz <marekm@linux.org.pl> writes:

> More changes for AVR binutils, mostly disassembler fixes.
> It should no longer segfault (tested on a binary file with all
> 64K possible opcodes), and its output can be used as valid input
> for the assembler (after removing the extra lines and columns).
> Also some minor cleanups and portability fixes.
> 
> Happy hacking,
> Marek
> 
> 
> gas/ChangeLog:
> 
> 2000-07-29  Marek Michalkiewicz  <marekm@linux.org.pl>
> 
> 	* config/tc-avr.c: Use PARAMS macro in function declarations.
> 	Don't declare md_pcrel_from_section (already in tc-avr.h).
> 	(avr_operands): Use AVR_UNDEF_P and AVR_SKIP_P macros.
> 	(avr_operand): Don't set (unsigned) op_mask to -1.
> 
> 
> include/opcode/ChangeLog:
> 
> 2000-07-29  Marek Michalkiewicz  <marekm@linux.org.pl>
> 
> 	* avr.h (AVR_UNDEF_P, AVR_SKIP_P, AVR_DISP0_P): New macros.
> 	Move related opcodes closer to each other.
> 	Minor changes in comments, list undefined opcodes.
> 
> 
> opcodes/ChangeLog:
> 
> 2000-07-29  Marek Michalkiewicz  <marekm@linux.org.pl>
> 
> 	* avr-dis.c (avr_operand): Use PARAMS macro in declaration.
> 	Change return type from void to int.  Check the combination
> 	of operands, return 1 if valid.  Fix to avoid BUF overflow.
> 	Report undefined combinations of operands in COMMENT.
> 	Report internal errors to stderr.  Output the adiw/sbiw
> 	constant operand in both decimal and hex.
> 	(print_insn_avr): Disassemble ldd/std with displacement of 0
> 	as ld/st.  Check avr_operand () return value, handle invalid
> 	combinations of operands like unknown opcodes.

Applied.

Denis.