This is the mail archive of the
binutils@sources.redhat.com
mailing list for the binutils project.
section ids
- To: binutils at sourceware dot cygnus dot com
- Subject: section ids
- From: Alan Modra <alan at linuxcare dot com dot au>
- Date: Mon, 10 Jul 2000 12:16:29 +1000 (EST)
I've checked in the following patch to make the section sequence ids
non-negative for the standard sections. There wasn't really anything
wrong with the original scheme, but this way is a little more logical, and
may avoid future surprises (eg. sprintf %x printing lots of digits and
overflowing buffers)
Alan Modra
--
Linuxcare. Support for the Revolution.
bfd/ChangeLog
* section.c (bfd_make_section_anyway): Start section_id at 0x10.
(STD_SECTION): Avoid negative ids, instead use 0 to 3.
--- section.c 2000/07/08 12:08:43 1.15
+++ section.c 2000/07/10 02:01:23
@@ -552,8 +552,8 @@ static const asymbol global_syms[] =
#define STD_SECTION(SEC, FLAGS, SYM, NAME, IDX) \
const asymbol * const SYM = (asymbol *) &global_syms[IDX]; \
const asection SEC = \
- /* name, id, index, next, flags, user_set_vma, reloc_done, */ \
- { NAME, -1-(IDX), 0, NULL, FLAGS, 0, 0, \
+ /* name, id, index, next, flags, user_set_vma, reloc_done, */ \
+ { NAME, IDX, 0, NULL, FLAGS, 0, 0, \
\
/* linker_mark, gc_mark, vma, lma, _cooked_size, _raw_size, */ \
0, 0, 0, 0, 0, 0, \
@@ -693,7 +693,7 @@ bfd_make_section_anyway (abfd, name)
bfd *abfd;
const char *name;
{
- static int section_id = 0;
+ static int section_id = 0x10; /* id 0 to 3 used by STD_SECTION. */
asection *newsect;
asection **prev = &abfd->sections;
asection *sect = abfd->sections;