This is the mail archive of the
binutils@sourceware.cygnus.com
mailing list for the binutils project.
Re: patch to accept \t as a character by `strings'
- To: Andreas Schwab <schwab at suse dot de>
- Subject: Re: patch to accept \t as a character by `strings'
- From: "David O'Brien" <obrien at FreeBSD dot org>
- Date: Thu, 11 May 2000 10:24:34 -0700
- Cc: binutils at sourceware dot cygnus dot com
- Organization: The NUXI BSD group
- References: <20000418183553.C7451@dragon.nuxi.com> <200005111705.TAA30177@hawking.suse.de>
- Reply-To: obrien at FreeBSD dot org
On Thu, May 11, 2000 at 07:05:43PM +0200, Andreas Schwab wrote:
> isblank is not part of ISO C.
No problem. :-) How about this patch then.
|> Below is a patch so that `strings' output matches that of other systems.
|> BSD since 1986/11/24 have defined <tab> to be a printable character (bug
|> report 4.3BSD/ucb/9). HP-UX (since at least 10.20), Irix (since at least
|> 5.3) also interprets <tab> this way.
2000-04-18 David O'Brien <obrien@FreeBSD.org>
* strings.c (isgraphic): Interpret <TAB> as a printable character,
analogous to <SPACE>.
Index: strings.c
===================================================================
RCS file: /cvs/src/src/binutils/strings.c,v
retrieving revision 1.5
diff -u -r1.5 strings.c
--- strings.c 2000/04/07 04:34:50 1.5
+++ strings.c 2000/05/11 17:22:53
@@ -60,9 +60,9 @@
#include "libiberty.h"
#ifdef isascii
-#define isgraphic(c) (isascii (c) && isprint (c))
+#define isgraphic(c) (isascii (c) && (isprint (c) || (c) == '\t'))
#else
-#define isgraphic(c) (isprint (c))
+#define isgraphic(c) (isprint (c) || (c) == '\t')
#endif
#ifndef errno