This is the mail archive of the
binutils@sourceware.cygnus.com
mailing list for the binutils project.
Re: AM30: patch for thinko in my previous patch
- To: binutils at sourceware dot cygnus dot com
- Subject: Re: AM30: patch for thinko in my previous patch
- From: Alexandre Oliva <aoliva at cygnus dot com>
- Date: 19 Apr 2000 04:57:53 -0300
- Organization: Cygnus Solutions, a Red Hat Company
- References: <orn1mxkzuq.fsf@zecarneiro.lsd.ic.unicamp.br>
On Apr 14, 2000, Alexandre Oliva <aoliva@cygnus.com> wrote:
> introduced a bug in the assembler. It would no longer recognize
> instructions marked as AM30 :-(
> Here's a patch. Ok to install? Release branch?
It turned out that the insns marked as AM30 are *not* supposed to be
available on AM33, so the patch was wrong. Nevertheless, there's
still a severe bug on current CVS (release branch included), that
causes it to reject any AM30-specific instructions. Here's a patch.
Ok to install?
Index: gas/ChangeLog
2000-04-12 Alexandre Oliva <aoliva@cygnus.com>
* config/tc-mn10300.c (HAVE_AM30): Define.
(md_assemble): Use it.
Index: gas/config/tc-mn10300.c
===================================================================
RCS file: /cvs/src/src/gas/config/tc-mn10300.c,v
retrieving revision 1.4
diff -u -r1.4 tc-mn10300.c
--- gas/config/tc-mn10300.c 2000/04/03 20:20:26 1.4
+++ gas/config/tc-mn10300.c 2000/04/19 07:50:52
@@ -125,6 +125,7 @@
};
#define HAVE_AM33 (current_machine == AM33)
+#define HAVE_AM30 (current_machine == AM30)
/* Opcode hash table. */
static struct hash_control *mn10300_hash;
@@ -944,7 +945,8 @@
/* If the instruction is not available on the current machine
then it can not possibly match. */
if (opcode->machine
- && !(opcode->machine == AM33 && HAVE_AM33))
+ && !(opcode->machine == AM33 && HAVE_AM33)
+ && !(opcode->machine == AM30 && HAVE_AM30))
goto error;
for (op_idx = 1, opindex_ptr = opcode->operands;
--
Alexandre Oliva Enjoy Guaranį, see http://www.ic.unicamp.br/~oliva/
Cygnus Solutions, a Red Hat company aoliva@{redhat, cygnus}.com
Free Software Developer and Evangelist CS PhD student at IC-Unicamp
oliva@{lsd.ic.unicamp.br, gnu.org} Write to mailing lists, not to me