This is the mail archive of the
binutils@sourceware.cygnus.com
mailing list for the binutils project.
revised revised patch for m32r gas relocations
- To: Donald Lindsay <dlindsay at cygnus dot com>
- Subject: revised revised patch for m32r gas relocations
- From: Doug Evans <dje at transmeta dot com>
- Date: Thu, 30 Mar 2000 14:24:47 -0800 (PST)
- Cc: binutils at sourceware dot cygnus dot com
- References: <Pine.LNX.4.10.10003301242590.6441-100000@hound.cygnus.com>
Donald Lindsay writes:
> This patch addresses both those concerns. The patch is relative
> to a file which has (only) the lo16 fix installed.
Thanks.
> - /* This part is from bfd_elf_generic_reloc.
> - If we're relocating, and this an external symbol, we don't want
> - to change anything. */
> - if (output_bfd != (bfd *) NULL
> - && (symbol->flags & BSF_SECTION_SYM) == 0
> - && reloc_entry->addend == 0)
> - {
> - reloc_entry->address += input_section->output_offset;
> - return bfd_reloc_ok;
> - }
> -
I believe deleting this is wrong (by "we don't want to change
anything", that also includes the hi16 relocs which would get
processed otherwise).
Sorry, my request may have been a bit ambiguous.
I checked your patch in with this part kept in.