This is the mail archive of the
binutils@sourceware.cygnus.com
mailing list for the binutils project.
Re: PATCH: minor hppa disasm cleanup
- To: "Jerry Quinn" <jquinn@nortelnetworks.com>
- Subject: Re: PATCH: minor hppa disasm cleanup
- From: Jeffrey A Law <law@cygnus.com>
- Date: Tue, 15 Jun 1999 01:21:09 -0600
- cc: binutils@sourceware.cygnus.com
- Reply-To: law@cygnus.com
In message <199906011505.LAA08672@wmtl249c.us.nortel.com>you write:
> In the pa disassembler, the 'E' code is always used for 0x0C opcodes
> where only left register halves occur. So the L/R selection bit at 25
> is always 0 and the test isn't required.
>
> This is patched against 990413, since I can't use cvs to update my
> snapshot (restrictive firewall) and this is the last one I have.
>
> Changelog entry:
>
> Tue Jun 1 11:03:02 EDT 1999 Jerry Quinn <jquinn@nortelnetworks.com>
>
> * hppa-dis.c (print_insn_hppa): Remove unnecessary test in 'E'
> code.
Is this really correct? Consider xmpyu, fmpyfadd & fmpynfadd, none of which
are 0xc opcodes, but all use 'E'
jeff