This is the mail archive of the binutils@sourceware.cygnus.com mailing list for the binutils project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]

Re: [PATCH] Fix for the gas problems when compiled with SunPRO


   Date: Wed, 9 Jun 1999 14:12:39 +0200
   From: Jakub Jelinek <jj@sunsite.ms.mff.cuni.cz>

   -		      if (isoctal (c = *s++))
   +		      c = *s++;
   +		      if (isoctal (c))

FYI, the GNU coding standards recommend against this kind of code.
See http://www.gnu.org/prep/standards_20.html#SEC20: ``Try to avoid
assignments inside if-conditions.''

The ctype functions have historically been implemented as macros, so
it is never safe to call them with arguments with side-effects, even
though the ANSI C standard permits it.

Ian

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]