This is the mail archive of the
binutils@sourceware.cygnus.com
mailing list for the binutils project.
A ld testsuite patch
- To: binutils@sourceware.cygnus.com
- Subject: A ld testsuite patch
- From: hjl@varesearch.com (H.J. Lu)
- Date: Fri, 4 Jun 1999 17:27:41 -0700 (PDT)
Hi,
I don't think if you don't clear nm_output first, the old value from
the last run will be removed. I got
/work/build/gnu/bin/binutils-static/ld/../binutils/nm-new tmpdir/4.x >tmpdir/nm.out
foo__1A== 0x08048074
FAIL: selective5
But when I ran the command by hand, I didn't see "foo__1A". With the
patch enclosed here, it passed.
However, I still got
/work/build/gnu/bin/binutils-normal/ld/../binutils/nm-new tmpdir/5.x >tmpdir/nm.out
foo__1A== 0x08048074
FAIL: selective6
Is this expected on Linux/x86?
Thanks.
--
H.J. Lu (hjl@gnu.org)
--
Fri Jun 4 17:20:47 1999 H.J. Lu <hjl@gnu.org>
* lib/ld-lib.exp (default_ld_nm): Clear nm_output first if
necessary.
Index: lib/ld-lib.exp
===================================================================
RCS file: /work/cvs/gnu/binutils/ld/testsuite/lib/ld-lib.exp,v
retrieving revision 1.1.1.1
diff -u -p -r1.1.1.1 ld-lib.exp
--- lib/ld-lib.exp 1999/06/03 18:02:11 1.1.1.1
+++ lib/ld-lib.exp 1999/06/05 00:16:05
@@ -207,6 +207,10 @@ proc default_ld_nm { nm object } {
return 0
}
+ if {[info exists nm_output]} {
+ unset nm_output
+ }
+
if ![info exists NMFLAGS] { set NMFLAGS "" }
verbose -log "$nm $NMFLAGS $object >tmpdir/nm.out"