This is the mail archive of the binutils@sourceware.cygnus.com mailing list for the binutils project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]

Re: Fix to common symbol detection


Hi Ian,

:    +   /* Local symbols do not count.  */
:    +   if (ELF_ST_BIND (sym->st_info) != STB_GLOBAL)
:    +     return false;
: 
: There are processor specific STB_* values too.  In principle they too
: should go to the hypothetical backend function.

Good point - I checked in the patch with the following change:

  /* Local symbols do not count, but target specific ones might.  */
  if (ELF_ST_BIND (sym->st_info) != STB_GLOBAL
      && ELF_ST_BIND (sym->st_info) < STB_LOOS)
    return false;

Cheers
	Nick

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]