Re: elf32.em

[Jeffrey A Law <law at cygnus dot com>]

  In message <19991027234806.10154.qmail@daffy.airs.com>you write:
  >      if (bfd_check_format (entry->the_bfd, bfd_object)
  > 	 && (entry->the_bfd->flags & DYNAMIC) != 0)
  >        {
  > 	 char *filname, *needed_name;
  > 
  > 	 ASSERT (entry->is_archive && entry->search_dirs_flag);
  > 
  > 	 /* Rather than duplicating the logic above.  Just use the
  > 	    filename we recorded earlier.o
  > 
  > 	    First strip off everything before the last '/'.  */
  > 	 filename = strrchr (entry->filename, '/');
  > 
  >    Shouldn't the variable be called 'filename'?
  > 
  > Actually, I think the uses of it should be filname, to avoid
  > shadowing.  Or we should just remove the declaration of filname, and
  > use the existing filename local.
  > 
  > Jeff, I'm not sure it's a good idea to try for the .sl extension on
  > every system type, given that it is only meaningful on HP/UX.  If
  > there is a long search path, it is a waste of time.  It is also
  > incorrect in principle.  You can test for a particular emulation using
  > #ifdef TARGET_IS_xxx.
I didn't know we could use TARGET_IS_xxx to do this stuff.  I'll certainly
change it.  I'm no fan of the current behavior applying to all targets.

Thanks for pointing it out.
jeff