This is the mail archive of the
binutils-cvs@sourceware.org
mailing list for the binutils project.
[binutils-gdb] ld: Add -z separate-code tests to frame.exp
- From: H.J.Lu <hjl at sourceware dot org>
- To: bfd-cvs at sourceware dot org
- Date: 19 Feb 2018 13:08:23 -0000
- Subject: [binutils-gdb] ld: Add -z separate-code tests to frame.exp
https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=f61f94ec1bf9cb3d32b38a90a1f5c2d58ececbfb
commit f61f94ec1bf9cb3d32b38a90a1f5c2d58ececbfb
Author: H.J. Lu <hjl.tools@gmail.com>
Date: Mon Feb 19 05:07:33 2018 -0800
ld: Add -z separate-code tests to frame.exp
On x86, "-z separate-code" leads to assertion fail at bfd/elf.c:5917.
Alsp skip tests if -shared isn't supported.
PR ld/22845
* testsuite/ld-elf/frame.exp: Skip if -shared isn't supported.
Add tests for "-z noseparate-code" and "-z separate-code".
Remove unsupported -shared check.
Diff:
---
ld/ChangeLog | 7 +++++++
ld/testsuite/ld-elf/frame.exp | 34 +++++++++++++++++++---------------
2 files changed, 26 insertions(+), 15 deletions(-)
diff --git a/ld/ChangeLog b/ld/ChangeLog
index 2f022ec..6d9ccc5 100644
--- a/ld/ChangeLog
+++ b/ld/ChangeLog
@@ -1,3 +1,10 @@
+2018-02-19 H.J. Lu <hongjiu.lu@intel.com>
+
+ PR ld/22845
+ * testsuite/ld-elf/frame.exp: Skip if -shared isn't supported.
+ Add tests for "-z noseparate-code" and "-z separate-code".
+ Remove unsupported -shared check.
+
2018-02-17 H.J. Lu <hongjiu.lu@intel.com>
PR ld/22845
diff --git a/ld/testsuite/ld-elf/frame.exp b/ld/testsuite/ld-elf/frame.exp
index 6cce42d..8862ff1 100644
--- a/ld/testsuite/ld-elf/frame.exp
+++ b/ld/testsuite/ld-elf/frame.exp
@@ -29,7 +29,7 @@ if ![is_elf_format] {
}
# No shared lib support on this target.
-if { [istarget "mcore-*-*"] } {
+if ![istarget shared] {
return
}
@@ -64,14 +64,16 @@ if { ![ld_assemble_flags $as $as_opt $srcdir/$subdir/tbss.s tmpdir/tbss.o ]
return
}
-if { [ld_link $ld tmpdir/frame.so "--shared tmpdir/frame.o tmpdir/tbss.o"] } {
- pass "$test1"
+if { [ld_link $ld tmpdir/frame.so "-z noseparate-code --shared tmpdir/frame.o tmpdir/tbss.o"] } {
+ pass "$test1 -z noseparate-code"
} else {
- if [string match "*shared not supported*" $link_output] {
- unsupported "-shared is not supported by this target"
- } else {
- fail "$test1"
- }
+ fail "$test1 -z noseparate-code"
+}
+
+if { [ld_link $ld tmpdir/frame.so "-z separate-code --shared tmpdir/frame.o tmpdir/tbss.o"] } {
+ pass "$test1 -z separate-code"
+} else {
+ fail "$test1 -z separate-code"
}
if ![ld_assemble_flags $as $as_opt $srcdir/$subdir/table.s tmpdir/table.o ] {
@@ -79,12 +81,14 @@ if ![ld_assemble_flags $as $as_opt $srcdir/$subdir/table.s tmpdir/table.o ] {
return
}
-if { [ld_link $ld tmpdir/table.so "--shared tmpdir/table.o tmpdir/tbss.o"] } {
- pass "$test2"
+if { [ld_link $ld tmpdir/table.so "-z noseparate-code --shared tmpdir/table.o tmpdir/tbss.o"] } {
+ pass "$test2 -z noseparate-code"
+} else {
+ fail "$test2 -z noseparate-code"
+}
+
+if { [ld_link $ld tmpdir/table.so "-z separate-code --shared tmpdir/table.o tmpdir/tbss.o"] } {
+ pass "$test2 -z separate-code"
} else {
- if [string match "*shared not supported*" $link_output] {
- unsupported "-shared is not supported by this target"
- } else {
- fail "$test2"
- }
+ fail "$test2 -z separate-code"
}