This is the mail archive of the
binutils-cvs@sourceware.org
mailing list for the binutils project.
[binutils-gdb] Fix a seg-fault in the ELF note parser when a note with an excessively large alignment is encountere
- From: Nick Clifton <nickc at sourceware dot org>
- To: bfd-cvs at sourceware dot org
- Date: 8 Feb 2018 10:29:31 -0000
- Subject: [binutils-gdb] Fix a seg-fault in the ELF note parser when a note with an excessively large alignment is encountere
https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=ef135d4314fd4c2d7da66b9d7b59af4a85b0f7e6
commit ef135d4314fd4c2d7da66b9d7b59af4a85b0f7e6
Author: Nick Clifton <nickc@redhat.com>
Date: Thu Feb 8 10:28:25 2018 +0000
Fix a seg-fault in the ELF note parser when a note with an excessively large alignment is encountered.
PR 22788
* elf.c (elf_parse_notes): Reject notes with excessuively large
alignments.
Diff:
---
bfd/ChangeLog | 6 ++++++
bfd/elf.c | 2 ++
2 files changed, 8 insertions(+)
diff --git a/bfd/ChangeLog b/bfd/ChangeLog
index 6dd9f47..7462f91 100644
--- a/bfd/ChangeLog
+++ b/bfd/ChangeLog
@@ -1,3 +1,9 @@
+2018-02-08 Nick Clifton <nickc@redhat.com>
+
+ PR 22788
+ * elf.c (elf_parse_notes): Reject notes with excessuively large
+ alignments.
+
2018-02-07 Alan Modra <amodra@gmail.com>
Revert 2018-01-17 Alan Modra <amodra@gmail.com>
diff --git a/bfd/elf.c b/bfd/elf.c
index dedf35f..db1e076 100644
--- a/bfd/elf.c
+++ b/bfd/elf.c
@@ -11012,6 +11012,8 @@ elf_parse_notes (bfd *abfd, char *buf, size_t size, file_ptr offset,
align is less than 4, we use 4 byte alignment. */
if (align < 4)
align = 4;
+ if (align != 4 && align != 8)
+ return FALSE;
p = buf;
while (p < buf + size)