This is the mail archive of the binutils-cvs@sourceware.org mailing list for the binutils project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

[binutils-gdb] Yet another fill-1 test fix


https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=94092126a05ee625bf05d48cb331472b8f87d235

commit 94092126a05ee625bf05d48cb331472b8f87d235
Author: Alan Modra <amodra@gmail.com>
Date:   Wed Oct 25 15:31:58 2017 +1030

    Yet another fill-1 test fix
    
    tic4x fails due to being a 4 octets per byte target, while tic54x is 2
    octets per byte.
    
    mmix still fails with
    fill-1.s:4: Error: unknown pseudo-op: `.l1:'
    fill-1.s:6: Error: unknown pseudo-op: `.l2:'
    fill-1.s:3: Error: .space specifies non-absolute value
    
    and if the labels are changed to L1 and L2 then mep-elf fails with
    fill-1.s:3: Error: .space specifies non-absolute value
    
    Since both of those look like they ought to be investigated by the
    target maintainers, I'm tweaking the test to fail on both targets.
    
    	* testsuite/gas/all/fill-1.d: Exclude tic4x and tic54x.
    	* testsuite/gas/all/fill-1.s: Use L1 rather than .L1.

Diff:
---
 gas/ChangeLog                  | 23 ++++++++++++++---------
 gas/testsuite/gas/all/fill-1.d |  1 +
 gas/testsuite/gas/all/fill-1.s |  4 ++--
 3 files changed, 17 insertions(+), 11 deletions(-)

diff --git a/gas/ChangeLog b/gas/ChangeLog
index 833e41c..4d7dcce 100644
--- a/gas/ChangeLog
+++ b/gas/ChangeLog
@@ -1,19 +1,24 @@
+2017-10-25  Alan Modra  <amodra@gmail.com>
+
+	* testsuite/gas/all/fill-1.d: Exclude tic4x and tic54x.
+	* testsuite/gas/all/fill-1.s: Use L1 rather than .L1.
+
 2017-10-24  Andrew Waterman  <andrew@sifive.com>
 
 	* testsuite/gas/riscv/c-addi16sp-fail.d: New test.
-	testsuite/gas/riscv/c-addi16sp-fail.l: Likewise.
-	testsuite/gas/riscv/c-addi16sp-fail.s: Likewise.
-	testsuite/gas/riscv/c-addi4spn-fail.d: Likewise.
-	testsuite/gas/riscv/c-addi4spn-fail.l: Likewise.
-	testsuite/gas/riscv/c-addi4spn-fail.s: Likewise.
-	testsuite/gas/riscv/riscv.exp: Add new tests.
+	* testsuite/gas/riscv/c-addi16sp-fail.l: Likewise.
+	* testsuite/gas/riscv/c-addi16sp-fail.s: Likewise.
+	* testsuite/gas/riscv/c-addi4spn-fail.d: Likewise.
+	* testsuite/gas/riscv/c-addi4spn-fail.l: Likewise.
+	* testsuite/gas/riscv/c-addi4spn-fail.s: Likewise.
+	* testsuite/gas/riscv/riscv.exp: Add new tests.
 
 2017-10-24  Andrew Waterman  <andrew@sifive.com>
 
 	* testsuite/gas/riscv/c-lui-fail.d: New testcase.
-	gas/testsuite/gas/riscv/c-lui-fail.l: Likewise.
-	gas/testsuite/gas/riscv/c-lui-fail.s: Likewise.
-	gas/testsuite/gas/riscv/riscv.exp: Likewise.
+	* gas/testsuite/gas/riscv/c-lui-fail.l: Likewise.
+	* gas/testsuite/gas/riscv/c-lui-fail.s: Likewise.
+	* gas/testsuite/gas/riscv/riscv.exp: Likewise.
 
 2017-10-24  H.J. Lu  <hongjiu.lu@intel.com>
 
diff --git a/gas/testsuite/gas/all/fill-1.d b/gas/testsuite/gas/all/fill-1.d
index da5933e..861eb0d 100644
--- a/gas/testsuite/gas/all/fill-1.d
+++ b/gas/testsuite/gas/all/fill-1.d
@@ -1,5 +1,6 @@
 #objdump: -s -j .data -j "\$DATA\$"
 #name: fill test with forward labels
+#not-target: tic4x-*-* tic54x-*-*
 
 .*: +file format .*
 
diff --git a/gas/testsuite/gas/all/fill-1.s b/gas/testsuite/gas/all/fill-1.s
index 34c52cc..d304812 100644
--- a/gas/testsuite/gas/all/fill-1.s
+++ b/gas/testsuite/gas/all/fill-1.s
@@ -1,7 +1,7 @@
 	.data
 	.dc.w 0x0a0a
-	.fill (.L2-.L1), 1, 0x0d
-.L1:
+	.fill (.L2-L1), 1, 0x0d
+L1:
 	.dc.w 0x0b0b
 .L2:
 	.dc.w 0x0c0c


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]