This is the mail archive of the binutils-cvs@sourceware.org mailing list for the binutils project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

[binutils-gdb] Use addr_mask to check VMA and LMA


https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=9216a6f33592c350ad50696d5571c82e47b71a5e

commit 9216a6f33592c350ad50696d5571c82e47b71a5e
Author: H.J. Lu <hjl.tools@gmail.com>
Date:   Tue Mar 14 09:09:54 2017 -0700

    Use addr_mask to check VMA and LMA
    
    Since BFD64 may be used on 32-bit address, we need to apply addr_mask
    to check VMA and LMA.
    
    	* ldlang.c (lang_check_section_addresses): Use addr_mask to
    	check VMA and LMA.

Diff:
---
 ld/ChangeLog | 5 +++++
 ld/ldlang.c  | 4 ++--
 2 files changed, 7 insertions(+), 2 deletions(-)

diff --git a/ld/ChangeLog b/ld/ChangeLog
index eb0c309..df8bb32 100644
--- a/ld/ChangeLog
+++ b/ld/ChangeLog
@@ -1,3 +1,8 @@
+2017-03-14  H.J. Lu  <hongjiu.lu@intel.com>
+
+	* ldlang.c (lang_check_section_addresses): Use addr_mask to
+	check VMA and LMA.
+
 2017-03-13  Nick Clifton  <nickc@redhat.com>
 
 	PR binutils/21202
diff --git a/ld/ldlang.c b/ld/ldlang.c
index a0638ea..8c1d829 100644
--- a/ld/ldlang.c
+++ b/ld/ldlang.c
@@ -4783,13 +4783,13 @@ lang_check_section_addresses (void)
   for (s = link_info.output_bfd->sections; s != NULL; s = s->next)
     {
       s_end = (s->vma + s->size) & addr_mask;
-      if (s_end != 0 && s_end < s->vma)
+      if (s_end != 0 && s_end < (s->vma & addr_mask))
 	einfo (_("%X%P: section %s VMA wraps around address space\n"),
 	       s->name);
       else
 	{
 	  s_end = (s->lma + s->size) & addr_mask;
-	  if (s_end != 0 && s_end < s->lma)
+	  if (s_end != 0 && s_end < (s->lma & addr_mask))
 	    einfo (_("%X%P: section %s LMA wraps around address space\n"),
 		   s->name);
 	}


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]