This is the mail archive of the binutils-cvs@sourceware.org mailing list for the binutils project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

[binutils-gdb] MIPS/opcodes: Only examine ELF file structures if SYMTAB_AVAILABLE


https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=91068ec6ae02e85c5ca4fbe3c6e214bd87bb872f

commit 91068ec6ae02e85c5ca4fbe3c6e214bd87bb872f
Author: Maciej W. Rozycki <macro@imgtec.com>
Date:   Mon Dec 19 11:35:14 2016 +0000

    MIPS/opcodes: Only examine ELF file structures if SYMTAB_AVAILABLE
    
    Correct commit 640c0ccdc980 ("some objdump -M options, better reg
    dumps"), <https://sourceware.org/ml/binutils/2002-12/msg00706.html>, and
    only execute code setting up disassembler options based on ELF file
    structures if SYMTAB_AVAILABLE is set.
    
    	opcodes/
    	* mips-dis.c (set_default_mips_dis_options) [SYMTAB_AVAILABLE]:
    	Only examine ELF file structures here.

Diff:
---
 opcodes/ChangeLog  | 5 +++++
 opcodes/mips-dis.c | 2 +-
 2 files changed, 6 insertions(+), 1 deletion(-)

diff --git a/opcodes/ChangeLog b/opcodes/ChangeLog
index 2618f90..7637018 100644
--- a/opcodes/ChangeLog
+++ b/opcodes/ChangeLog
@@ -1,5 +1,10 @@
 2016-12-19  Maciej W. Rozycki  <macro@imgtec.com>
 
+	* mips-dis.c (set_default_mips_dis_options) [SYMTAB_AVAILABLE]:
+	Only examine ELF file structures here.
+
+2016-12-19  Maciej W. Rozycki  <macro@imgtec.com>
+
 	* mips-dis.c (set_default_mips_dis_options) [BFD64]: Only call
 	`bfd_mips_elf_get_abiflags' here.
 
diff --git a/opcodes/mips-dis.c b/opcodes/mips-dis.c
index cd9893e..8c35759 100644
--- a/opcodes/mips-dis.c
+++ b/opcodes/mips-dis.c
@@ -839,7 +839,6 @@ set_default_mips_dis_options (struct disassemble_info *info)
       mips_cp1_names = chosen_arch->cp1_names;
       mips_hwr_names = chosen_arch->hwr_names;
     }
-#endif
 
   /* Update settings according to the ELF file header flags.  */
   if (info->flavour == bfd_target_elf_flavour && info->section != NULL)
@@ -866,6 +865,7 @@ set_default_mips_dis_options (struct disassemble_info *info)
       else if (header->e_flags & EF_MIPS_ARCH_ASE_MDMX)
 	mips_ase |= ASE_MDMX;
     }
+#endif
 }
 
 static void


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]