This is the mail archive of the
binutils-cvs@sourceware.org
mailing list for the binutils project.
[binutils-gdb] PR20932, Internal error during record link assignment
- From: Alan Modra <amodra at sourceware dot org>
- To: bfd-cvs at sourceware dot org
- Date: 8 Dec 2016 11:49:18 -0000
- Subject: [binutils-gdb] PR20932, Internal error during record link assignment
https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=8e2a4f11d477986aa360a3b588d35a194efe58f8
commit 8e2a4f11d477986aa360a3b588d35a194efe58f8
Author: Alan Modra <amodra@gmail.com>
Date: Thu Dec 8 09:51:00 2016 +1030
PR20932, Internal error during record link assignment
PR ld/20932
* elflink.c (bfd_elf_record_link_assignment): Handle warning symbols.
Diff:
---
bfd/ChangeLog | 5 +++++
bfd/elflink.c | 10 +++++-----
2 files changed, 10 insertions(+), 5 deletions(-)
diff --git a/bfd/ChangeLog b/bfd/ChangeLog
index 7c21bb8..1c1dd90 100644
--- a/bfd/ChangeLog
+++ b/bfd/ChangeLog
@@ -1,3 +1,8 @@
+2016-12-08 Alan Modra <amodra@gmail.com>
+
+ PR ld/20932
+ * elflink.c (bfd_elf_record_link_assignment): Handle warning symbols.
+
2016-12-07 Nick Clifton <nickc@redhat.com>
PR ld/20932
diff --git a/bfd/elflink.c b/bfd/elflink.c
index 49c3803..9b4482d 100644
--- a/bfd/elflink.c
+++ b/bfd/elflink.c
@@ -577,6 +577,9 @@ bfd_elf_record_link_assignment (bfd *output_bfd,
if (h == NULL)
return provide;
+ if (h->root.type == bfd_link_hash_warning)
+ h = (struct elf_link_hash_entry *) h->root.u.i.link;
+
if (h->versioned == unknown)
{
/* Set versioned if symbol version is unknown. */
@@ -624,11 +627,8 @@ bfd_elf_record_link_assignment (bfd *output_bfd,
hv->root.u.i.link = (struct bfd_link_hash_entry *) h;
(*bed->elf_backend_copy_indirect_symbol) (info, h, hv);
break;
- case bfd_link_hash_warning:
- /* See PR 20932 for a reproducer. */
- _bfd_error_handler (_("%B: Attempt to assign a value to warning symbol '%s'"),
- output_bfd, name);
- bfd_set_error (bfd_error_invalid_operation);
+ default:
+ BFD_FAIL ();
return FALSE;
}