This is the mail archive of the binutils-cvs@sourceware.org mailing list for the binutils project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

[binutils-gdb] [AArch64][SVE 02/32] Avoid hard-coded limit in indented_print


https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=bd11d5d83775e6d05c8e49f2233fb1cf883ff5b4

commit bd11d5d83775e6d05c8e49f2233fb1cf883ff5b4
Author: Richard Sandiford <richard.sandiford@arm.com>
Date:   Wed Sep 21 16:48:06 2016 +0100

    [AArch64][SVE 02/32] Avoid hard-coded limit in indented_print
    
    The maximum indentation needed by aarch64-gen.c grows as more
    instructions are added to aarch64-tbl.h.  Rather than having to
    increase the indentation limit to a higher value, it seemed better
    to replace it with "%*s".
    
    opcodes/
    	* aarch64-gen.c (indented_print): Avoid hard-coded indentation limit.

Diff:
---
 opcodes/ChangeLog     | 4 ++++
 opcodes/aarch64-gen.c | 6 +-----
 2 files changed, 5 insertions(+), 5 deletions(-)

diff --git a/opcodes/ChangeLog b/opcodes/ChangeLog
index 4208ba1..b47f034 100644
--- a/opcodes/ChangeLog
+++ b/opcodes/ChangeLog
@@ -1,3 +1,7 @@
+2016-09-21  Richard Sandiford  <richard.sandiford@arm.com>
+
+	* aarch64-gen.c (indented_print): Avoid hard-coded indentation limit.
+
 2016-09-15  Claudiu Zissulescu  <claziss@synopsys.com>
 
 	* arc-dis.c (find_format): Walk the linked list pointed by einsn.
diff --git a/opcodes/aarch64-gen.c b/opcodes/aarch64-gen.c
index ed0834a..a62f6c8 100644
--- a/opcodes/aarch64-gen.c
+++ b/opcodes/aarch64-gen.c
@@ -378,13 +378,9 @@ initialize_decoder_tree (void)
 static void __attribute__ ((format (printf, 2, 3)))
 indented_print (unsigned int indent, const char *format, ...)
 {
-  /* 80 number of spaces pluc a NULL terminator.  */
-  static const char spaces[81] =
-    "                                                                                ";
   va_list ap;
   va_start (ap, format);
-  assert (indent <= 80);
-  printf ("%s", &spaces[80 - indent]);
+  printf ("%*s", (int) indent, "");
   vprintf (format, ap);
   va_end (ap);
 }


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]