This is the mail archive of the
binutils-cvs@sourceware.org
mailing list for the binutils project.
[binutils-gdb] fix undefined reference to bfd_link_plugin_object_p during link
- From: Joel Brobecker <brobecke at sourceware dot org>
- To: bfd-cvs at sourceware dot org
- Date: 24 Jun 2016 17:02:55 -0000
- Subject: [binutils-gdb] fix undefined reference to bfd_link_plugin_object_p during link
https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=08ce1d723ea3360a8ae52a4a4bd395ec984563eb
commit 08ce1d723ea3360a8ae52a4a4bd395ec984563eb
Author: Joel Brobecker <brobecker@adacore.com>
Date: Fri Jun 24 12:16:24 2016 -0400
fix undefined reference to bfd_link_plugin_object_p during link
When configured with the default options, GDB currently fails to link,
due to an undefined reference to bfd_link_plugin_object_p, coming from
elflink.c:
#ifdef BFD_SUPPORTS_PLUGINS
|| (abfd->plugin_format == bfd_plugin_unknown
&& bfd_link_plugin_object_p (abfd))
#endif
This is because BFD_SUPPORTS_PLUGINS is always defined. It is its value
that determines whether plugin support is enabled or not.
bfd/ChangeLog:
* elflink.c: Check the value of BFD_SUPPORTS_PLUGINS rather
than its existance.
Diff:
---
bfd/elflink.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/bfd/elflink.c b/bfd/elflink.c
index bb83854..ad8493b 100644
--- a/bfd/elflink.c
+++ b/bfd/elflink.c
@@ -28,7 +28,7 @@
#include "safe-ctype.h"
#include "libiberty.h"
#include "objalloc.h"
-#ifdef BFD_SUPPORTS_PLUGINS
+#if BFD_SUPPORTS_PLUGINS
#include "plugin.h"
#endif
@@ -3134,7 +3134,7 @@ elf_link_is_defined_archive_symbol (bfd * abfd, carsym * symdef)
object file is an IR object, give linker LTO plugin a chance to
get the correct symbol table. */
if (abfd->plugin_format == bfd_plugin_yes
-#ifdef BFD_SUPPORTS_PLUGINS
+#if BFD_SUPPORTS_PLUGINS
|| (abfd->plugin_format == bfd_plugin_unknown
&& bfd_link_plugin_object_p (abfd))
#endif