This is the mail archive of the binutils-cvs@sourceware.org mailing list for the binutils project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

[binutils-gdb] xtensa: typedef enums when defining them


https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=d05584d3eeab4cb1c1d85d8dfdfef56827e03b3d

commit d05584d3eeab4cb1c1d85d8dfdfef56827e03b3d
Author: Trevor Saunders <tbsaunde+binutils@tbsaunde.org>
Date:   Mon Mar 28 05:42:02 2016 -0400

    xtensa: typedef enums when defining them
    
    I think this is the more typical way to do this.  Its also slightly shorter and
    less repeditive.
    
    gas/ChangeLog:
    
    2016-06-01  Trevor Saunders  <tbsaunde+binutils@tbsaunde.org>
    
    	* config/xtensa-relax.h: Move typedefs of enums to the enums
    	definition.

Diff:
---
 gas/ChangeLog             |  5 +++++
 gas/config/xtensa-relax.h | 16 ++++++----------
 2 files changed, 11 insertions(+), 10 deletions(-)

diff --git a/gas/ChangeLog b/gas/ChangeLog
index 0dcdcef..ff6adf3 100644
--- a/gas/ChangeLog
+++ b/gas/ChangeLog
@@ -1,5 +1,10 @@
 2016-06-01  Trevor Saunders  <tbsaunde+binutils@tbsaunde.org>
 
+	* config/xtensa-relax.h: Move typedefs of enums to the enums
+	definition.
+
+2016-06-01  Trevor Saunders  <tbsaunde+binutils@tbsaunde.org>
+
 	* config/tc-ns32k.c (bit_fix_new): Replace obstack-alloc with XOBNEW
 	macro.
 
diff --git a/gas/config/xtensa-relax.h b/gas/config/xtensa-relax.h
index 0bad423..6458579 100644
--- a/gas/config/xtensa-relax.h
+++ b/gas/config/xtensa-relax.h
@@ -91,10 +91,7 @@ struct req_or_option_list
 
 /* Operand types and constraints on operands:  */
 
-typedef enum op_type OpType;
-typedef enum cmp_op CmpOp;
-
-enum op_type
+typedef enum op_type
 {
   OP_CONSTANT,
   OP_OPERAND,
@@ -107,13 +104,13 @@ enum op_type
   OP_LITERAL,
   OP_FREEREG,
   OP_LABEL
-};
+} OpType;
 
-enum cmp_op
+typedef enum cmp_op
 {
   OP_EQUAL,
   OP_NOTEQUAL,
-};
+} CmpOp;
 
 struct precondition
 {
@@ -143,14 +140,13 @@ struct build_op
 };
 
 typedef struct build_instr BuildInstr;
-typedef enum instr_type InstrType;
 
-enum instr_type
+typedef enum instr_type
 {
   INSTR_INSTR,
   INSTR_LITERAL_DEF,
   INSTR_LABEL_DEF
-};
+} InstrType;
 
 struct build_instr
 {


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]