[binutils-gdb] remove pointless assignment

[Trevor Saunders <tbsaunde at sourceware dot org>]

https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=92fce9bd7a4d5732fe9db05b7ebaef4ab858e69a

commit 92fce9bd7a4d5732fe9db05b7ebaef4ab858e69a
Author: Trevor Saunders <tbsaunde+binutils@tbsaunde.org>
Date:   Wed Apr 13 05:03:22 2016 -0400

    remove pointless assignment
    
    Presumably this was supposed to be regname[sizeof (regname) - 1] but was typoed
    to regname[sizeof (rename) - 1].  However that should be unnecessary because
    sprintf should null terminate.  As is this assignment is invalid ISO C because
    rename refers to the function rename (), and sizeof on functions is undefined.
    In GNU C C the size of functions is 1 so the expression is the same as
    regname[0].  The following call to sprintf () clearly will over right that, so
    the statement either has no effect or is invalid.  Given that it seems safe to
    just remove it.  While we are there correct the size of regname, and switch
    from snprintf to sprintf since we know the exact length of the result.
    
    gas/ChangeLog:
    
    2016-04-15  Trevor Saunders  <tbsaunde+binutils@tbsaunde.org>
    
    	* config/tc-mips.c (md_begin): Remove useless assignment.

Diff:
---
 gas/ChangeLog        | 4 ++++
 gas/config/tc-mips.c | 9 ++++-----
 2 files changed, 8 insertions(+), 5 deletions(-)

diff --git a/gas/ChangeLog b/gas/ChangeLog
index bfa91e7..f9b5afe 100644
--- a/gas/ChangeLog
+++ b/gas/ChangeLog
@@ -1,3 +1,7 @@
+2016-04-15  Trevor Saunders  <tbsaunde+binutils@tbsaunde.org>
+
+	* config/tc-mips.c (md_begin): Remove useless assignment.
+
 2016-04-15  H.J. Lu  <hongjiu.lu@intel.com>
 
 	* Makefile.in: Regenerated with automake 1.11.6.
diff --git a/gas/config/tc-mips.c b/gas/config/tc-mips.c
index 118b91d..bfc639e 100644
--- a/gas/config/tc-mips.c
+++ b/gas/config/tc-mips.c
@@ -3601,21 +3601,20 @@ md_begin (void)
 
   for (i = 0; i < 32; i++)
     {
-      char regname[7];
+      char regname[6];
 
       /* R5900 VU0 floating-point register.  */
-      regname[sizeof (rename) - 1] = 0;
-      snprintf (regname, sizeof (regname) - 1, "$vf%d", i);
+      sprintf (regname, "$vf%d", i);
       symbol_table_insert (symbol_new (regname, reg_section,
 				       RTYPE_VF | i, &zero_address_frag));
 
       /* R5900 VU0 integer register.  */
-      snprintf (regname, sizeof (regname) - 1, "$vi%d", i);
+      sprintf (regname, "$vi%d", i);
       symbol_table_insert (symbol_new (regname, reg_section,
 				       RTYPE_VI | i, &zero_address_frag));
 
       /* MSA register.  */
-      snprintf (regname, sizeof (regname) - 1, "$w%d", i);
+      sprintf (regname, "$w%d", i);
       symbol_table_insert (symbol_new (regname, reg_section,
 				       RTYPE_MSA | i, &zero_address_frag));
     }