This is the mail archive of the
binutils-cvs@sourceware.org
mailing list for the binutils project.
[binutils-gdb] Always create dynsym section with dynamic sections
- From: H.J.Lu <hjl at sourceware dot org>
- To: bfd-cvs at sourceware dot org
- Date: 23 Feb 2016 00:31:53 -0000
- Subject: [binutils-gdb] Always create dynsym section with dynamic sections
https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=1a6e6083b69dcb695e175b5dc02342391da6ba22
commit 1a6e6083b69dcb695e175b5dc02342391da6ba22
Author: H.J. Lu <hjl.tools@gmail.com>
Date: Mon Feb 22 16:30:30 2016 -0800
Always create dynsym section with dynamic sections
We should always create the dynsym section, even if it is empty, with
dynamic sections.
* elflink.c (_bfd_elf_link_renumber_dynsyms): Always create the
dynsym section, even if it is empty, with dynamic sections.
Diff:
---
bfd/ChangeLog | 5 +++++
bfd/elflink.c | 6 +++---
2 files changed, 8 insertions(+), 3 deletions(-)
diff --git a/bfd/ChangeLog b/bfd/ChangeLog
index dd1a308..1e0f6a1 100644
--- a/bfd/ChangeLog
+++ b/bfd/ChangeLog
@@ -1,5 +1,10 @@
2016-02-22 H.J. Lu <hongjiu.lu@intel.com>
+ * elflink.c (_bfd_elf_link_renumber_dynsyms): Always create the
+ dynsym section, even if it is empty, with dynamic sections.
+
+2016-02-22 H.J. Lu <hongjiu.lu@intel.com>
+
* syms.c: Remove BSF_COMMON from comments.
* bfd-in2.h: Regenerated.
diff --git a/bfd/elflink.c b/bfd/elflink.c
index c7672ed..89a6dea 100644
--- a/bfd/elflink.c
+++ b/bfd/elflink.c
@@ -875,9 +875,9 @@ _bfd_elf_link_renumber_dynsyms (bfd *output_bfd,
&dynsymcount);
/* There is an unused NULL entry at the head of the table which
- we must account for in our count. Unless there weren't any
- symbols, which means we'll have no table at all. */
- if (dynsymcount != 0)
+ we must account for in our count. We always create the dynsym
+ section, even if it is empty, with dynamic sections. */
+ if (elf_hash_table (info)->dynamic_sections_created)
++dynsymcount;
elf_hash_table (info)->dynsymcount = dynsymcount;