[binutils-gdb] Correct assertion in NIOS2 linker to allow signed 16-buit immediate values.

[Nick Clifton <nickc at sourceware dot org>]

https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=83da6e748c8f105f07e17f53aa6b99ed7867ff5f

commit 83da6e748c8f105f07e17f53aa6b99ed7867ff5f
Author: Nick Clifton <nickc@redhat.com>
Date:   Wed Feb 10 11:25:59 2016 +0000

    Correct assertion in NIOS2 linker to allow signed 16-buit immediate values.
    
    	PR 19405
    	* elf32-nios2.c (nios2_elf32_install_imm16): Allow for signed
    	immediate values.
    	* elf-eh-frame.c (_bfd_elf_discard_section_eh_frame): Limit the
    	number of messages about FDE encoding preventing .eh_frame_hdr
    	generation.

Diff:
---
 bfd/ChangeLog      |  9 +++++++++
 bfd/elf-eh-frame.c | 18 +++++++++++++++---
 bfd/elf32-nios2.c  |  2 +-
 3 files changed, 25 insertions(+), 4 deletions(-)

diff --git a/bfd/ChangeLog b/bfd/ChangeLog
index 3489873..40739c8 100644
--- a/bfd/ChangeLog
+++ b/bfd/ChangeLog
@@ -1,3 +1,12 @@
+2016-02-10  Nick Clifton  <nickc@redhat.com>
+
+	PR 19405
+	* elf32-nios2.c (nios2_elf32_install_imm16): Allow for signed
+	immediate values.
+	* elf-eh-frame.c (_bfd_elf_discard_section_eh_frame): Limit the
+	number of messages about FDE encoding preventing .eh_frame_hdr
+	generation.
+
 2016-02-09  Nick Clifton  <nickc@redhat.com>
 
 	* oasys.c (oasys_archive_p): Fix indentation.
diff --git a/bfd/elf-eh-frame.c b/bfd/elf-eh-frame.c
index 0500cd3..e787ee9 100644
--- a/bfd/elf-eh-frame.c
+++ b/bfd/elf-eh-frame.c
@@ -1369,14 +1369,26 @@ _bfd_elf_discard_section_eh_frame
 		     && ent->make_relative == 0)
 		    || (ent->fde_encoding & 0x70) == DW_EH_PE_aligned))
 	      {
+		static int num_warnings_issued = 0;
+
 		/* If a shared library uses absolute pointers
 		   which we cannot turn into PC relative,
 		   don't create the binary search table,
 		   since it is affected by runtime relocations.  */
 		hdr_info->u.dwarf.table = FALSE;
-		(*info->callbacks->einfo)
-		  (_("%P: FDE encoding in %B(%A) prevents .eh_frame_hdr"
-		     " table being created.\n"), abfd, sec);
+		if (num_warnings_issued < 10)
+		  {
+		    (*info->callbacks->einfo)
+		      (_("%P: FDE encoding in %B(%A) prevents .eh_frame_hdr"
+			 " table being created.\n"), abfd, sec);
+		    num_warnings_issued ++;
+		  }
+		else if (num_warnings_issued == 10)
+		  {
+		    (*info->callbacks->einfo)
+		      (_("%P: Further warnings about FDE encoding preventing .eh_frame_hdr generation dropped.\n"));
+		    num_warnings_issued ++;
+		  }
 	      }
 	    ent->removed = 0;
 	    hdr_info->u.dwarf.fde_count++;
diff --git a/bfd/elf32-nios2.c b/bfd/elf32-nios2.c
index 3f72b11..b19169c 100644
--- a/bfd/elf32-nios2.c
+++ b/bfd/elf32-nios2.c
@@ -1905,7 +1905,7 @@ nios2_elf32_install_imm16 (asection *sec, bfd_vma offset, bfd_vma value)
 {
   bfd_vma word = bfd_get_32 (sec->owner, sec->contents + offset);
 
-  BFD_ASSERT(value <= 0xffff);
+  BFD_ASSERT (value <= 0xffff || ((bfd_signed_vma) value) >= -0xffff);
 
   bfd_put_32 (sec->owner, word | ((value & 0xffff) << 6),
 	      sec->contents + offset);