This is the mail archive of the binutils-cvs@sourceware.org mailing list for the binutils project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

[binutils-gdb] S/390: Get rid of superfluous parameter to s390_elf_allocate_ifunc_dyn_relocs.


https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=61643fbadb17932965e5c02db75ec3f8e211d7b1

commit 61643fbadb17932965e5c02db75ec3f8e211d7b1
Author: Andreas Krebbel <krebbel@linux.vnet.ibm.com>
Date:   Mon Oct 19 13:08:27 2015 +0200

    S/390: Get rid of superfluous parameter to s390_elf_allocate_ifunc_dyn_relocs.
    
    bfd/ChangeLog:
    	* elf-s390-common.c (s390_elf_allocate_ifunc_dyn_relocs): Remove
    	`head' parameter.
    	* elf32-s390.c (allocate_dynrelocs): Don't use last parameter.
    	* elf64-s390.c (allocate_dynrelocs): Don't use last parameter.

Diff:
---
 bfd/ChangeLog         | 7 +++++++
 bfd/elf-s390-common.c | 4 ++--
 bfd/elf32-s390.c      | 3 +--
 bfd/elf64-s390.c      | 3 +--
 4 files changed, 11 insertions(+), 6 deletions(-)

diff --git a/bfd/ChangeLog b/bfd/ChangeLog
index 862664a..6eec665 100644
--- a/bfd/ChangeLog
+++ b/bfd/ChangeLog
@@ -1,3 +1,10 @@
+2015-10-22  Andreas Krebbel  <krebbel@linux.vnet.ibm.com>
+
+	* elf-s390-common.c (s390_elf_allocate_ifunc_dyn_relocs): Remove
+	`head' parameter.
+	* elf32-s390.c (allocate_dynrelocs): Don't use last parameter.
+	* elf64-s390.c (allocate_dynrelocs): Don't use last parameter.
+
 2015-10-20  Hans-Peter Nilsson  <hp@bitrange.com>
 
 	* mmo.c (mmo_write_symbols_and_terminator): Correct printed value
diff --git a/bfd/elf-s390-common.c b/bfd/elf-s390-common.c
index 6b5b17b..2daeef6 100644
--- a/bfd/elf-s390-common.c
+++ b/bfd/elf-s390-common.c
@@ -87,12 +87,12 @@ s390_elf_create_ifunc_sections (bfd *abfd, struct bfd_link_info *info)
 
 static bfd_boolean
 s390_elf_allocate_ifunc_dyn_relocs (struct bfd_link_info *info,
-				    struct elf_link_hash_entry *h,
-				    struct elf_dyn_relocs **head)
+				    struct elf_link_hash_entry *h)
 {
   struct elf_dyn_relocs *p;
   struct elf_link_hash_table *htab;
   struct elf_s390_link_hash_entry *eh = (struct elf_s390_link_hash_entry*)h;
+  struct elf_dyn_relocs **head = &eh->dyn_relocs;
 
   htab = elf_hash_table (info);
   eh->ifunc_resolver_address = h->root.u.def.value;
diff --git a/bfd/elf32-s390.c b/bfd/elf32-s390.c
index dc2d80f..509d8f9 100644
--- a/bfd/elf32-s390.c
+++ b/bfd/elf32-s390.c
@@ -1787,8 +1787,7 @@ allocate_dynrelocs (struct elf_link_hash_entry *h, void * inf)
   /* Since STT_GNU_IFUNC symbol must go through PLT, we handle it
      here if it is defined and referenced in a non-shared object.  */
   if (s390_is_ifunc_symbol_p (h) && h->def_regular)
-    return s390_elf_allocate_ifunc_dyn_relocs (info, h,
-					       &eh->dyn_relocs);
+    return s390_elf_allocate_ifunc_dyn_relocs (info, h);
   else if (htab->elf.dynamic_sections_created
 	   && h->plt.refcount > 0)
     {
diff --git a/bfd/elf64-s390.c b/bfd/elf64-s390.c
index 7cc0489..d988b12 100644
--- a/bfd/elf64-s390.c
+++ b/bfd/elf64-s390.c
@@ -1734,8 +1734,7 @@ allocate_dynrelocs (struct elf_link_hash_entry *h,
   /* Since STT_GNU_IFUNC symbol must go through PLT, we handle it
      here if it is defined and referenced in a non-shared object.  */
   if (s390_is_ifunc_symbol_p (h) && h->def_regular)
-    return s390_elf_allocate_ifunc_dyn_relocs (info, h,
-					       &eh->dyn_relocs);
+    return s390_elf_allocate_ifunc_dyn_relocs (info, h);
   else if (htab->elf.dynamic_sections_created
 	   && h->plt.refcount > 0)
     {


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]