This is the mail archive of the binutils-cvs@sourceware.org mailing list for the binutils project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

[binutils-gdb] [aarch64] Remove argument pc from disas_aarch64_insn


https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=7232d38966babb802e9d8d0e9e591346a7b93d96

commit 7232d38966babb802e9d8d0e9e591346a7b93d96
Author: Yao Qi <yao.qi@linaro.org>
Date:   Wed Sep 30 17:03:57 2015 +0100

    [aarch64] Remove argument pc from disas_aarch64_insn
    
    I happen to see that argument pc is not used inside disas_aarch64_insn
    at all.  This patch is to remove it.
    
    OK to apply?
    
    opcodes:
    
    2015-10-02  Yao Qi  <yao.qi@linaro.org>
    
    	* aarch64-dis.c (disas_aarch64_insn): Remove argument PC.
    	(print_insn_aarch64_word): Caller updated.

Diff:
---
 opcodes/ChangeLog     | 5 +++++
 opcodes/aarch64-dis.c | 5 ++---
 2 files changed, 7 insertions(+), 3 deletions(-)

diff --git a/opcodes/ChangeLog b/opcodes/ChangeLog
index 48fa37d..051c42b 100644
--- a/opcodes/ChangeLog
+++ b/opcodes/ChangeLog
@@ -1,3 +1,8 @@
+2015-10-02  Yao Qi  <yao.qi@linaro.org>
+
+	* aarch64-dis.c (disas_aarch64_insn): Remove argument PC.
+	(print_insn_aarch64_word): Caller updated.
+
 2015-09-29  Dominik Vogt  <vogt@linux.vnet.ibm.com>
 
 	* s390-mkopc.c (main): Parse htm and vx flag.
diff --git a/opcodes/aarch64-dis.c b/opcodes/aarch64-dis.c
index 5fec4ee..e0faeb5 100644
--- a/opcodes/aarch64-dis.c
+++ b/opcodes/aarch64-dis.c
@@ -2032,8 +2032,7 @@ user_friendly_fixup (aarch64_inst *inst)
 /* Decode INSN and fill in *INST the instruction information.  */
 
 static int
-disas_aarch64_insn (uint64_t pc ATTRIBUTE_UNUSED, uint32_t insn,
-		    aarch64_inst *inst)
+disas_aarch64_insn (uint32_t insn, aarch64_inst *inst)
 {
   const aarch64_opcode *opcode = aarch64_opcode_lookup (insn);
 
@@ -2172,7 +2171,7 @@ print_insn_aarch64_word (bfd_vma pc,
        addresses, since the addend is not currently pc-relative.  */
     pc = 0;
 
-  ret = disas_aarch64_insn (pc, word, &inst);
+  ret = disas_aarch64_insn (word, &inst);
 
   if (((word >> 21) & 0x3ff) == 1)
     {


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]