This is the mail archive of the
binutils-cvs@sourceware.org
mailing list for the binutils project.
[binutils-gdb/binutils-2_25-branch] PowerPC gold assertion on missing global entry stub
- From: Alan Modra <amodra at sourceware dot org>
- To: bfd-cvs at sourceware dot org
- Date: 5 Jun 2015 14:58:20 -0000
- Subject: [binutils-gdb/binutils-2_25-branch] PowerPC gold assertion on missing global entry stub
https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=99381983ab1b423b93bfa3f6fbe7115079717255
commit 99381983ab1b423b93bfa3f6fbe7115079717255
Author: Alan Modra <amodra@gmail.com>
Date: Tue Apr 28 13:28:29 2015 +0930
PowerPC gold assertion on missing global entry stub
Global entry stubs are used on ELFv2 to provide addresses for
functions not defined in a non-PIC executable but whose address is
taken, in much the same way as PLT stub code is used on other
targets to provide function addresses. We don't want to insert a
global entry stub just because (bogus) debug info refers to the
address of a non-local function, but we also don't want gold to die.
* powerpc.cc (Target_powerpc::Relocate::relocate): Don't assert
on missing global entry stub due to bogus debug info.
Diff:
---
gold/ChangeLog | 4 ++++
gold/powerpc.cc | 9 ++++++---
2 files changed, 10 insertions(+), 3 deletions(-)
diff --git a/gold/ChangeLog b/gold/ChangeLog
index b2225e0..f554ee8 100644
--- a/gold/ChangeLog
+++ b/gold/ChangeLog
@@ -1,6 +1,10 @@
2015-06-05 Alan Modra <amodra@gmail.com>
Apply from master
+ 2015-04-28 Alan Modra <amodra@gmail.com>
+ * powerpc.cc (Target_powerpc::Relocate::relocate): Don't assert
+ on missing global entry stub due to bogus debug info.
+
2015-03-24 Alan Modra <amodra@gmail.com>
PR 18147
* powerpc.cc (Target_powerpc::Relocate::relocate): Don't report
diff --git a/gold/powerpc.cc b/gold/powerpc.cc
index e7f3554..3766f72 100644
--- a/gold/powerpc.cc
+++ b/gold/powerpc.cc
@@ -6748,8 +6748,11 @@ Target_powerpc<size, big_endian>::Relocate::relocate(
&& !is_branch_reloc(r_type))
{
unsigned int off = target->glink_section()->find_global_entry(gsym);
- gold_assert(off != (unsigned int)-1);
- value = target->glink_section()->global_entry_address() + off;
+ if (off != (unsigned int)-1)
+ {
+ value = target->glink_section()->global_entry_address() + off;
+ has_stub_value = true;
+ }
}
else
{
@@ -6771,8 +6774,8 @@ Target_powerpc<size, big_endian>::Relocate::relocate(
rela.get_r_addend());
gold_assert(off != invalid_address);
value = stub_table->stub_address() + off;
+ has_stub_value = true;
}
- has_stub_value = true;
}
if (r_type == elfcpp::R_POWERPC_GOT16