This is the mail archive of the
binutils-cvs@sourceware.org
mailing list for the binutils project.
[binutils-gdb] [AArch64] Call abort() consistently in unhandled stub switch statements.
- From: Marcus Shawcroft <mshawcroft at sourceware dot org>
- To: bfd-cvs at sourceware dot org
- Date: 4 Mar 2015 12:41:35 -0000
- Subject: [binutils-gdb] [AArch64] Call abort() consistently in unhandled stub switch statements.
https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=8e2fe09f70e721bfd8aaa0690537640a44538f25
commit 8e2fe09f70e721bfd8aaa0690537640a44538f25
Author: Marcus Shawcroft <marcus.shawcroft@arm.com>
Date: Mon Mar 2 12:12:37 2015 +0000
[AArch64] Call abort() consistently in unhandled stub switch statements.
Ensure we hard stop via abort() for unhandled stub types rather than
continuing either silently (or noisly with a BFD_FAIL()).
Call abort() giving a hard stop rather than BFD_FAIL () for unhandled
stub types.
Diff:
---
bfd/ChangeLog | 6 ++++++
bfd/elfnn-aarch64.c | 11 ++++-------
2 files changed, 10 insertions(+), 7 deletions(-)
diff --git a/bfd/ChangeLog b/bfd/ChangeLog
index d115513..a257a66 100644
--- a/bfd/ChangeLog
+++ b/bfd/ChangeLog
@@ -1,3 +1,9 @@
+2015-03-04 Marcus Shawcroft <marcus.shawcroft@arm.com>
+
+ * elfnn-aarch64.c (aarch64_build_one_stub): Call abort.
+ (aarch64_size_one_stub): Likewise.
+ (aarch64_map_one_stub): Likewise.
+
2015-03-04 Andreas Arnez <arnez@linux.vnet.ibm.com>
* cpu-s390.c (N): New macro.
diff --git a/bfd/elfnn-aarch64.c b/bfd/elfnn-aarch64.c
index 8a66299..6397006 100644
--- a/bfd/elfnn-aarch64.c
+++ b/bfd/elfnn-aarch64.c
@@ -2445,8 +2445,7 @@ aarch64_build_one_stub (struct bfd_hash_entry *gen_entry,
template_size = sizeof (aarch64_erratum_835769_stub);
break;
default:
- BFD_FAIL ();
- return FALSE;
+ abort ();
}
for (i = 0; i < (template_size / sizeof template[0]); i++)
@@ -2504,7 +2503,7 @@ aarch64_build_one_stub (struct bfd_hash_entry *gen_entry,
break;
default:
- break;
+ abort ();
}
return TRUE;
@@ -2535,9 +2534,7 @@ aarch64_size_one_stub (struct bfd_hash_entry *gen_entry,
size = sizeof (aarch64_erratum_835769_stub);
break;
default:
- BFD_FAIL ();
- return FALSE;
- break;
+ abort ();
}
size = (size + 7) & ~7;
@@ -6552,7 +6549,7 @@ aarch64_map_one_stub (struct bfd_hash_entry *gen_entry, void *in_arg)
return FALSE;
break;
default:
- BFD_FAIL ();
+ abort ();
}
return TRUE;