This is the mail archive of the
binutils-cvs@sourceware.org
mailing list for the binutils project.
gdb and binutils branch master updated. 8acbedd60e1045bf8d37b29ddd25c2c8b6a302a9
- From: kseitz at sourceware dot org
- To: binutils-cvs at sourceware dot org
- Date: 11 Dec 2014 17:41:47 -0000
- Subject: gdb and binutils branch master updated. 8acbedd60e1045bf8d37b29ddd25c2c8b6a302a9
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "gdb and binutils".
The branch, master has been updated
via 8acbedd60e1045bf8d37b29ddd25c2c8b6a302a9 (commit)
from 540feddfde2c93f242e6f54be5feb641f263c5f3 (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=8acbedd60e1045bf8d37b29ddd25c2c8b6a302a9
commit 8acbedd60e1045bf8d37b29ddd25c2c8b6a302a9
Author: Keith Seitz <keiths@redhat.com>
Date: Thu Dec 11 09:39:24 2014 -0800
This commit causes hundreds of core file regressions in gdb:
commit f64e188b58f4aab4cbd03aa6e9fc1aa602546e26
Author: Nick Clifton <nickc@redhat.com>
Date: Tue Dec 9 12:42:18 2014 +0000
More fixes for memory access violations triggered by fuzzed binaries.
[snip]
* elf.c (elf_parse_notes): Check that the namedata is long enough
for the string comparison that is about to be performed.
(elf_read_notes): Zero-terminate the note buffer.
This change to elf_parse_notes is the culprit:
+ for (i = ARRAY_SIZE (grokers); i--;)
+ if (in.namesz >= sizeof grokers[i].string - 1
+ && strncmp (in.namedata, grokers[i].string,
+ sizeof (grokers[i].string) - 1) == 0)
Note how this applies sizeof to grokers[i].string...
bfd/ChangeLog
* elf.c (elf_parse_notes): Define convenience macro
GROKER_ELEMENT to add elements to 'grokers'.
Use grokers.len instead of sizeof in string comparisons.
-----------------------------------------------------------------------
Summary of changes:
bfd/ChangeLog | 8 ++++++++
bfd/elf.c | 31 ++++++++++++++++++-------------
2 files changed, 26 insertions(+), 13 deletions(-)
hooks/post-receive
--
gdb and binutils