This is the mail archive of the
archer@sourceware.org
mailing list for the Archer project.
Re: How to distinguish inheritance from containment?
- From: Paul Pluzhnikov <ppluzhnikov at google dot com>
- To: Richard Ward <richard dot j dot ward1 at googlemail dot com>
- Cc: archer at sourceware dot org, Tom Tromey <tromey at redhat dot com>
- Date: Wed, 1 Jul 2009 14:05:00 -0700
- Subject: Re: How to distinguish inheritance from containment?
- References: <20090701203842.32FE076BC0@localhost> <4A4BCC63.5020407@googlemail.com>
On Wed, Jul 1, 2009 at 1:51 PM, Richard
Ward<richard.j.ward1@googlemail.com> wrote:
> I sent a patch to archer that did just that about two weeks ago, if you want
> it (not that it take that long to write one yourself). It had "Info about
> base class in gdb.Type" in the subject line.
Ah, missed it the first time. The patch looks good to me, except I think
"inherited" is clearer than "base_class". If you don't like "inherited",
perhaps "is_base_class" ?
Also, you'll need a proper ChangeLog entry for both gdb/ChangeLog and
gdb/doc/ChangeLog. Something like:
ChangeLog:
2009-05-28 Richard Ward <richard.j.ward1@googlemail.com>
* python/python-type.c (convert_field): New attribute "base_class".
doc/ChangeLog:
2009-05-28 Richard Ward <richard.j.ward1@googlemail.com>
* gdb.texinfo (Types In Python): Describe "base_class".
Tom, any chance this could go in?
Thanks,
--
Paul Pluzhnikov