Re: [python][rfc] Attempt to print the base class if a there is no Python pretty-printer for a derived class.

[Tom Tromey <tromey at redhat dot com>]

>>>>> "Phil" == Phil Muldoon <pmuldoon@redhat.com> writes:

Looking pretty good :)

Phil> +  /* Attempt to run the Python pretty-printers on the base class of
Phil> +  the derived class. */

The second line here needs more indentation.
"the" should line up with "Attempt".
Also you need an extra space after the period.

Silly nit-picking... :)

Phil> +  if (!options->raw)
Phil> +    if (n_baseclasses > 0)
Phil> +      {  
Phil> +	

Declare baseclass and result here, not at the top of the function.

Phil>    /* First, print out baseclasses such that we don't print
Phil>       duplicates of virtual baseclasses.  */
 
Does this logic continue to work properly if one of the virtual
baseclasses has a pretty-printer?

Please write a couple test cases for this functionality.

thanks,
Tom