This is the mail archive of the
archer@sourceware.org
mailing list for the Archer project.
Re: [RFC] Patch for gnats pr 2495
Phil Muldoon wrote:
Tom Tromey wrote:
"Phil" == Phil Muldoon <pmuldoon@redhat.com> writes:
Phil> This patch addresses that by gating access to std::terminate in an
Phil> inferior function call.
Sounds good. The patch looks nice! In fact the majority of my
comments are on the string constants :-
I've attached an updated patch. I think I caught all of your suggestions.
Sorry, I thought I checked this fix in before I submitted the patch for,
but:
+ if (unwind_on_terminating_exception_p)
+ {
+ tm = lookup_minimal_symbol ("std::terminate()", NULL, NULL);
+ if (tm != NULL)
+ terminate_bp = set_momentary_breakpoint_at_pc
+ (SYMBOL_VALUE_ADDRESS (tm), bp_breakpoint);
+ make_cleanup_delete_breakpoint (terminate_bp);
+ }
should read:
+ if (unwind_on_terminating_exception_p)
+ {
+ tm = lookup_minimal_symbol ("std::terminate()", NULL, NULL);
+ if (tm != NULL)
+ {
+ terminate_bp = set_momentary_breakpoint_at_pc
+ (SYMBOL_VALUE_ADDRESS (tm), bp_breakpoint);
+ make_cleanup_delete_breakpoint (terminate_bp);
+ }
+ }